Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix focus issue introduced in v2.11.0 #6043

Merged
merged 6 commits into from
Jan 22, 2025
Merged

fix(core): fix focus issue introduced in v2.11.0 #6043

merged 6 commits into from
Jan 22, 2025

Conversation

cpgruber
Copy link
Contributor

@cpgruber cpgruber commented Jan 21, 2025 •
edited
Loading

Changes Overview

A change was introduced in v2.11.0 to fix losing text selection/focus when using the focus command on Android. This PR effectively reverts this change, while updating the conditional logic to be more narrowly scoped to solve the issue for Android as originally intended.

Implementation Approach

The previous logic in this function was scoped to just iOS, so I simply added an Android check in the same if statement. The removal of the if statement altogether introduced new behavior to all implementors of focus, which in my case (Chrome, web) led to undesirable behavior of the page jumping to the top of the editor.

Testing Done

No testing done -- no devices to test with

Verification Steps

No verification done

Additional Notes

I think this is a pretty simple solution when you compare the previous and current logic implemented in this code block. Admittedly I have no real way to verify this other than the change introduced to my app when I installed @tiptap/core v2.11.0. Hoping someone else can take it from here, given the small size of the change requested.

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

#5992

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ba50f9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit ba50f9a
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/679118084dc1ce0007df4df7
😎 Deploy Preview https://deploy-preview-6043--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cpgruber cpgruber mentioned this pull request Jan 21, 2025
Closed
1 task
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@6043

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@6043

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@6043

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@6043

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@6043

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@6043

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@6043

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@6043

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@6043

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@6043

@tiptap/extension-collaboration-cursor

npm i https://pkg.pr.new/@tiptap/extension-collaboration-cursor@6043

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@6043

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@6043

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@6043

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@6043

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@6043

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@6043

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@6043

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@6043

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@6043

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@6043

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@6043

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@6043

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@6043

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@6043

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@6043

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@6043

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@6043

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@6043

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@6043

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@6043

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@6043

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@6043

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@6043

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@6043

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@6043

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@6043

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@6043

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@6043

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@6043

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@6043

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@6043

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@6043

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@6043

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@6043

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@6043

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@6043

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@6043

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@6043

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@6043

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@6043

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@6043

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@6043

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@6043

commit: ba50f9a

@nperez0111 nperez0111 merged commit fa63c47 into ueberdosis:develop Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nperez0111 nperez0111 nperez0111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpgruber @nperez0111